test: increase bufsize in child process write test #13626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-child-process-stdio-big-write-end was failing on ubuntu1604-arm64 because the while loop that was supposed to fill up the buffer ended up being an infinite loop. This increases the size of the writes in the loop by 1K until the buffer fills up. Fixes: nodejs#13603
Trott
added
child_process
Trott
force-pushed
the
is-that-freedom-rock-well-turn-it-up
branch
from
77aab91
to
30c1e00
Compare
|
ubuntu1604-arm64 is green in the CI! Victory! (Unless something else comes back red...) |
|
I'd like to expedite this to get CI back to green. /cc @nodejs/testing And a rare /cc @isaacs because they wrote the test originally and may know reasons this approach may be inadvisable. |
|
CI is green! |
refack
approved these changes
Jun 12, 2017
| @@ -51,14 +51,15 @@ function parent() { | |||
| // Write until the buffer fills up. | |||
| let buf; | |||
| do { | |||
| buf = Buffer.alloc(BUFSIZE, '.'); | |||
| sent += BUFSIZE; | |||
| bufsize += 1024; | |||
There was a problem hiding this comment.
Now it definitely looks like a /pummel/...
But:
ok 184 parallel/test-child-process-stdio-big-write-end
---
duration_ms: 0.332
🤷♂️
👍 |
aqrln
approved these changes
Jun 12, 2017
tniessen
approved these changes
Jun 12, 2017
cjihrig
approved these changes
Jun 12, 2017
Probably a stupid question, but why exactly does the buffer fill become an infinite loop on this machine? Is it because there's so much RAM? |
|
@gibfahn This is not necessarily caused by too much RAM, but the child process might just clear the buffer too quickly. I think Linux uses something around 64k as the pipe buffer (not all the RAM!). |
3 tasks
|
Landed in b71d677 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 12, 2017
test-child-process-stdio-big-write-end was failing on ubuntu1604-arm64 because the while loop that was supposed to fill up the buffer ended up being an infinite loop. This increases the size of the writes in the loop by 1K until the buffer fills up. PR-URL: nodejs#13626 Fixes: nodejs#13603 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 17, 2017
test-child-process-stdio-big-write-end was failing on ubuntu1604-arm64 because the while loop that was supposed to fill up the buffer ended up being an infinite loop. This increases the size of the writes in the loop by 1K until the buffer fills up. PR-URL: #13626 Fixes: #13603 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
test-child-process-stdio-big-write-end was failing on ubuntu1604-arm64 because the while loop that was supposed to fill up the buffer ended up being an infinite loop. This increases the size of the writes in the loop by 1K until the buffer fills up. PR-URL: #13626 Fixes: #13603 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
test-child-process-stdio-big-write-end was failing on ubuntu1604-arm64 because the while loop that was supposed to fill up the buffer ended up being an infinite loop. This increases the size of the writes in the loop by 1K until the buffer fills up. PR-URL: #13626 Fixes: #13603 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-child-process-stdio-big-write-end was failing on ubuntu1604-arm64
because the while loop that was supposed to fill up the buffer ended up
being an infinite loop.
This increases the size of the writes in the loop by 1K until the buffer
fills up.
Fixes: #13603
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test child_process